Yes please. I have found 5 places within your code that has this text, but I would like to have it confirmed that I have located the correct ones to change.
I have amended the code (And added a bit of logic so that different tables come back with different phrases when no itmes are returned). Yes, I know I will loose that when there is an update and I have therefore made a backup. ;)
Yes, it would be good to have this facility added to the core product if possible in the future.
When the table returns zero rows and the message is displayed if you then resize the browser window - from wide to narrow .. or narrow to wide - the portion of the table that has the no items message does not react in the same way as the grid headings.. i.e. they will be a different sizes
When this occurs if you refresh the screen then the header and the no items message cell will become the same size. Again, you can see this with the links I gave you below.
(It happens with the standard text too, i.e. your own code without my changes)
Very strange. It looks like the issue is that the column headers have some custom CSS which gives them the 100px and that is why it is behaving like that. Also I found a lot of media max and min width so can you please tell me do you have some custom CSS for the column headers.
No. I do not have any CSS for the column headers, though I have some to hide the search boxes. Making the search boxes viewable doesn't change anything though.
1) In the first 2 coulms of my table I have set the column width to 100. So maybe that is what you are seeing when you said there may be some custom css in the column header? 2 BUT .. I have just created a 2 new tables and made sure there is no extra css anywhere on the page. See the 2 top most tables on my "test" page:
Just enter aaa into the date field to select no records.
You will see that the top one works fine and the 2nd' one does not. The difference? In the DoesNotWork table I have enabled the "Collapse column on mobile devices" on the DoesWork table I have left it alone.
The columns that you choose to be hidden on mobile devices do not appear after you resize the window from wide to narrow ( which is OK ) the column width that you set for the first 2 columns have that 100px width and that is why this is happening. Can you please tell me if you remove that width for first 2 columns do you still have this issue.
Sorry, I should have said ... all the columns in both those tables have no width set. As I did say .. they only difference between the two (the one that works and the one that does not on http://www.keepwerking.co.uk/aaa/) is the fact that in the DoesNotWork table I have enabled the "Collapse column on mobile devices"
I currently have 2.0.2, I am planning to update to the latest version this weekend. When i have done that I will create a brand new page with brand new tables and investigate further. I will let you know my findings afterwards.
I added 2 tables. The only difference is that the table that works has the "Table that Works > Display > Allow collapsing on mobiles and tablets" option un selected / switched off. The results are now different to what I was experiencing before, but there is still an issue when starting the tables small and makeing them wider:
To replicate:
Step 1: Start with a wide window and Go to http://www.keepwerking.co.uk/atabletest/ You will see too tables entitled TABLE THAT WORKS and below it another entitled TABLE THAT DOES NOT WORK
Enter "AAA" into the date field of date column of both tables so that the queries return no rows.
Make the window narrower. You will see that the table and the "No matching records found" respond as expected. You can even make the window wider and all will be fine.
Step 2: Start with a narrow window and Go to http://www.keepwerking.co.uk/atabletest/ 2 columns in the table entitled TABLE THAT DOES NOT WORK should have collapsed. Refresh the screen to make sure.
Make the window wider. You will see that the table table entitled TABLE THAT DOES NOT WORK expands but the area where the "No matching records found" text is does not.
Hopefully you will now see what I mean.
AN UPDATE:
I have just noticed something strange.
If I use a filter in the URL then the functionality works as expected:
Which is the same page, but has the date column pre filled with "aaa" and this time you will see that the "No matching records found" area responds as expected from a wider window start and/or a narrow window start.
Brilliant (ahh well .. not brilliant that there IS an issue - just that now I know it's not just me)
I look forward to a future fix.
For me it is not a high priority as it would be rare that I have no items returned and that users would change the width of the window. And even then it is only a minor cosmetic issue.
Is there any way to amend the "No matching records found" text when no rows are returned for each table?
HI jcsatujp,
Thank you for your purchase.
It is possible to change the text of it but it will require some code changing which will be overwritten by the next update.
If you are interested I can tell you which files to change.
Best regards.
Kind Regards,
Miloš Jovanović
[email protected]
Rate my support
wpDataTables: FAQ | Facebook | Twitter | Instagram | Front-end and back-end demo | Docs
Amelia: FAQ | Facebook | Twitter | Instagram | Amelia demo sites | Docs | Discord Community
You can try wpDataTables add-ons before purchasing on these sandbox sites:
Powerful Filters | Gravity Forms Integration for wpDataTables | Formidable Forms Integration for wpDataTables | Master-Detail Tables
Hello,
Yes please. I have found 5 places within your code that has this text, but I would like to have it confirmed that I have located the correct ones to change.
Thank you.
Hi jcsatujp,
In file
wp-content/plugins/wpdatatables/source/class.wdttools.php around line 288 find this code:
'sZeroRecords' => __('No matching records found', 'wpdatatables'),And change it to your desire.
Let me know the result.
Best regards.
Kind Regards,
Miloš Jovanović
[email protected]
Rate my support
wpDataTables: FAQ | Facebook | Twitter | Instagram | Front-end and back-end demo | Docs
Amelia: FAQ | Facebook | Twitter | Instagram | Amelia demo sites | Docs | Discord Community
You can try wpDataTables add-ons before purchasing on these sandbox sites:
Powerful Filters | Gravity Forms Integration for wpDataTables | Formidable Forms Integration for wpDataTables | Master-Detail Tables
Hello,
So sorry for the delay in getting back to you.
I have amended the code (And added a bit of logic so that different tables come back with different phrases when no itmes are returned). Yes, I know I will loose that when there is an update and I have therefore made a backup. ;)
Yes, it would be good to have this facility added to the core product if possible in the future.
Exampels can be seen here:
http://www.keepwerking.co.uk/concerts/?wdt_column_filter%5B0%5D=20%2F11&wdt_column_filter%5B2%5D=aa&wdt_column_filter%5B3%5D
and here:
http://www.keepwerking.co.uk/collection/?wdt_column_filter%5B0%5D&wdt_column_filter%5B1%5D&wdt_column_filter%5B2%5D=aaa&wdt_column_filter%5B3%5D&wdt_column_filter%5B4%5D&wdt_column_filter%5B5%5D
Thank you again for your help.
Hi jcsatujp,
I can see your result, glad that you managed to achieve that and good job.
This is something that we will look to add for our upcoming versions of our plugin.
Thank you again for sharing your ideas with us.
Best regards.
Kind Regards,
Miloš Jovanović
[email protected]
Rate my support
wpDataTables: FAQ | Facebook | Twitter | Instagram | Front-end and back-end demo | Docs
Amelia: FAQ | Facebook | Twitter | Instagram | Amelia demo sites | Docs | Discord Community
You can try wpDataTables add-ons before purchasing on these sandbox sites:
Powerful Filters | Gravity Forms Integration for wpDataTables | Formidable Forms Integration for wpDataTables | Master-Detail Tables
Before I sign off this issue.
Can I point out a related problem?
When the table returns zero rows and the message is displayed if you then resize the browser window - from wide to narrow .. or narrow to wide - the portion of the table that has the no items message does not react in the same way as the grid headings.. i.e. they will be a different sizes
When this occurs if you refresh the screen then the header and the no items message cell will become the same size. Again, you can see this with the links I gave you below.
(It happens with the standard text too, i.e. your own code without my changes)
Hi jcsatujp,
I can see the issue.
Very strange. It looks like the issue is that the column headers have some custom CSS which gives them the 100px and that is why it is behaving like that.
Also I found a lot of media max and min width so can you please tell me do you have some custom CSS for the column headers.
Best regards.
Kind Regards,
Miloš Jovanović
[email protected]
Rate my support
wpDataTables: FAQ | Facebook | Twitter | Instagram | Front-end and back-end demo | Docs
Amelia: FAQ | Facebook | Twitter | Instagram | Amelia demo sites | Docs | Discord Community
You can try wpDataTables add-ons before purchasing on these sandbox sites:
Powerful Filters | Gravity Forms Integration for wpDataTables | Formidable Forms Integration for wpDataTables | Master-Detail Tables
No. I do not have any CSS for the column headers, though I have some to hide the search boxes. Making the search boxes viewable doesn't change anything though.
Hi jcsatujp,
Very strange because I was not able to reproduce it on my side ( attachment)
Also the version that I am using is 2.1 which was released yesterday.
Can you please tell me did you have the same issue when viewing the tables from mobile devices or tables or just when you resize it on the desktop.
Best regards.
Kind Regards,
Miloš Jovanović
[email protected]
Rate my support
wpDataTables: FAQ | Facebook | Twitter | Instagram | Front-end and back-end demo | Docs
Amelia: FAQ | Facebook | Twitter | Instagram | Amelia demo sites | Docs | Discord Community
You can try wpDataTables add-ons before purchasing on these sandbox sites:
Powerful Filters | Gravity Forms Integration for wpDataTables | Formidable Forms Integration for wpDataTables | Master-Detail Tables
Hello,
I have checked a couple of things.
1) In the first 2 coulms of my table I have set the column width to 100. So maybe that is what you are seeing when you said there may be some custom css in the column header?
2 BUT .. I have just created a 2 new tables and made sure there is no extra css anywhere on the page. See the 2 top most tables on my "test" page:
http://www.keepwerking.co.uk/aaa/
Just enter aaa into the date field to select no records.
You will see that the top one works fine and the 2nd' one does not. The difference? In the DoesNotWork table I have enabled the "Collapse column on mobile devices" on the DoesWork table I have left it alone.
Hi jcsatujp,
That might be the cause of this issue.
The columns that you choose to be hidden on mobile devices do not appear after you resize the window from wide to narrow ( which is OK ) the column width that you set for the first 2 columns have that 100px width and that is why this is happening.
Can you please tell me if you remove that width for first 2 columns do you still have this issue.
Best regards.
Kind Regards,
Miloš Jovanović
[email protected]
Rate my support
wpDataTables: FAQ | Facebook | Twitter | Instagram | Front-end and back-end demo | Docs
Amelia: FAQ | Facebook | Twitter | Instagram | Amelia demo sites | Docs | Discord Community
You can try wpDataTables add-ons before purchasing on these sandbox sites:
Powerful Filters | Gravity Forms Integration for wpDataTables | Formidable Forms Integration for wpDataTables | Master-Detail Tables
Sorry, I should have said ... all the columns in both those tables have no width set. As I did say .. they only difference between the two (the one that works and the one that does not on http://www.keepwerking.co.uk/aaa/) is the fact that in the DoesNotWork table I have enabled the "Collapse column on mobile devices"
Hi jcsatujp,
Can you please tell me which version of our plugin do you use.
Best regards.
Kind Regards,
Miloš Jovanović
[email protected]
Rate my support
wpDataTables: FAQ | Facebook | Twitter | Instagram | Front-end and back-end demo | Docs
Amelia: FAQ | Facebook | Twitter | Instagram | Amelia demo sites | Docs | Discord Community
You can try wpDataTables add-ons before purchasing on these sandbox sites:
Powerful Filters | Gravity Forms Integration for wpDataTables | Formidable Forms Integration for wpDataTables | Master-Detail Tables
Hello,
I currently have 2.0.2, I am planning to update to the latest version this weekend. When i have done that I will create a brand new page with brand new tables and investigate further. I will let you know my findings afterwards.
Regards.
I have upgraded to 2.1
I created a brand new page. Nothing fancy.
I added 2 tables. The only difference is that the table that works has the "Table that Works > Display > Allow collapsing on mobiles and tablets" option un selected / switched off. The results are now different to what I was experiencing before, but there is still an issue when starting the tables small and makeing them wider:
To replicate:
Step 1: Start with a wide window and Go to http://www.keepwerking.co.uk/atabletest/ You will see too tables entitled TABLE THAT WORKS and below it another entitled TABLE THAT DOES NOT WORK
Enter "AAA" into the date field of date column of both tables so that the queries return no rows.
Make the window narrower. You will see that the table and the "No matching records found" respond as expected. You can even make the window wider and all will be fine.
Step 2: Start with a narrow window and Go to http://www.keepwerking.co.uk/atabletest/ 2 columns in the table entitled TABLE THAT DOES NOT WORK should have collapsed. Refresh the screen to make sure.
Make the window wider. You will see that the table table entitled TABLE THAT DOES NOT WORK expands but the area where the "No matching records found" text is does not.
Hopefully you will now see what I mean.
AN UPDATE:
I have just noticed something strange.
If I use a filter in the URL then the functionality works as expected:
Go to here http://www.keepwerking.co.uk/atabletest/?wdt_column_filter[0]=aaa
Which is the same page, but has the date column pre filled with "aaa" and this time you will see that the "No matching records found" area responds as expected from a wider window start and/or a narrow window start.
Most strange. ;)
Hi jcsatujp,
Yes I can see it now.
Very strange, also the URl filtering is working like you said below.
Can you please tell me is it possible for testing purposes to change the theme and see if the issue still persist.
Best regards.
Kind Regards,
Miloš Jovanović
[email protected]
Rate my support
wpDataTables: FAQ | Facebook | Twitter | Instagram | Front-end and back-end demo | Docs
Amelia: FAQ | Facebook | Twitter | Instagram | Amelia demo sites | Docs | Discord Community
You can try wpDataTables add-ons before purchasing on these sandbox sites:
Powerful Filters | Gravity Forms Integration for wpDataTables | Formidable Forms Integration for wpDataTables | Master-Detail Tables
I changed the theme.
I had the same, incorrect, results. i.e. the issue still persists.
Hi jcsatujp,
I now confirm definitely that this is happening also on our side.
I will forward this issue to my team and I will get back to you as soon as they give me an answer.
This is only happening when responsive option is checked.
Thank you for reporting this.
Best regards.
Kind Regards,
Miloš Jovanović
[email protected]
Rate my support
wpDataTables: FAQ | Facebook | Twitter | Instagram | Front-end and back-end demo | Docs
Amelia: FAQ | Facebook | Twitter | Instagram | Amelia demo sites | Docs | Discord Community
You can try wpDataTables add-ons before purchasing on these sandbox sites:
Powerful Filters | Gravity Forms Integration for wpDataTables | Formidable Forms Integration for wpDataTables | Master-Detail Tables
Brilliant (ahh well .. not brilliant that there IS an issue - just that now I know it's not just me)
I look forward to a future fix.
For me it is not a high priority as it would be rare that I have no items returned and that users would change the width of the window. And even then it is only a minor cosmetic issue.
but thank you for your time.